search

zalando-stups / kio

The application registry in the STUPS ecosystem
http://docs.stups.io/en/latest/components/kio.html
Other
23 stars 11 forks source link

Migrate CDP docker dependency URL to container-registry #143

Closed scherniavsky closed 1 month ago

scherniavsky commented 1 month ago

Migrate CDP docker dependency URL to container-registry in order to fix the issue with builds not being triggered.

The container-registry.zalando.net/library/eclipse-temurin-8-jdk image is already used in Dockerfile.

scherniavsky commented 1 month ago

:+1:

kanistha commented 1 month ago

👍

scherniavsky commented 1 month ago

@kanistha I guess because you have private membership visibility, Zappr doesn't recognize you as part of Zalando org.

tkrop commented 1 month ago

@scherniavsky I'm a bit concerned that the image you are referencing contains internal data, that is not supposed to be published to the open source repository. Can we somehow verify, whether the base image is supposed to fulfill the requirement permanently.

scherniavsky commented 1 month ago

@tkrop this PR doesn't change the used image. As you can see, it has already been set to container-registry.zalando.net/library/eclipse-temurin-8-jdk:latest in: https://github.com/zalando-stups/kio/commit/c4c57398a4fb78e4e440f2577797b3a79d85e134

The PR only makes the CDP dependency image consistent with the used Docker image.

But in general, as opensource images are also used internally, they must be compliant. And the only way for this - is to base it on a compliant Docker image, if I understand it correctly.

tkrop commented 1 month ago

@scherniavsky sorry, you are right. I should have been concerned before, but since it was added by Joa, I might have missed it.

tkrop commented 1 month ago

:+1: