Extend returned App model with scm_url in [/apps] endpoint

zalando-stups / kio

The application registry in the STUPS ecosystem

http://docs.stups.io/en/latest/components/kio.html

Other

23 stars 11 forks source link

Extend returned App model with scm_url in [/apps] endpoint #22

Closed kanuku closed 9 years ago

kanuku commented 9 years ago

Right now to retrieve all the SCM-URL's from zalando-stups/kio we need to call 2 endpoints.

First we call /apps which includes all the id's of all applications.
Second we call /apps/id for each id we got on the first call.

It would be great if zalando/kontrolletti#60 could call /apps endpoint once to get all registered SCM-url's in the App json-object. Is it possible to extend the returned json object to include the scm-url and time-created?

prayerslayer commented 9 years ago

Does this have practical implications for you or is it only convenience?

Aside from that: Since we check in fullstop for the presence of all URL fields one could consider those part of the basic data of an application. Following from there it would be reasonable to provide them along with the auditing fields (created, last_modified) in /apps.

kanuku commented 9 years ago

Yes it is more convenient, but would also lower the amount of traffic and calls made to kio. kio returns now around 800 apps from the /apps endpoint. To get more detailed information about all 800 returned apps, kontrolletti must request the detailed info separately for each of the 800 apps, in its own http-request. Thank you once again for the quick reaction :+1: !