search

zalando-stups / kio

The application registry in the STUPS ecosystem
http://docs.stups.io/en/latest/components/kio.html
Other
23 stars 11 forks source link

Application version must be immutable #41

Closed mrandi closed 5 years ago

mrandi commented 8 years ago

Change PUT method to a PUT idempotent as the application version must be immutable

sarnowski commented 8 years ago

Whats the reasoning here? Why ist POST immutable and PUT is not?

hjacobs commented 8 years ago

Yes, please keep PUT (idempotent) and make sure that a repeated PUT works if the content is the same and will throw an error if the content is different (immutability).

mrandi commented 8 years ago

PUT idempotent is perfect!

Thought POST as a create but you are right PUT idempotent is better.

@sarnowski because right now the PUT also do an update and remove all approvals.

sarnowski commented 8 years ago

Yes, that was actually the initial idea. If you change something in the version information, all previous approvals are invalid are are removed.

mrandi commented 8 years ago

so we have not an immutable version, and that is the point. Or?

hjacobs commented 8 years ago

hmm, it should be immutable!

hjacobs commented 5 years ago

Versions were removed.