Closed rafaelcaricio closed 8 years ago
Thanks, I'll first check if we break existing patterns with this (unlikely though).
@prayerslayer any updates?
pls update with the latest status
Hi, will do on Monday. Sorry for the delay!
@prayerslayer Any updates?
Ahhhh I'm so sorry :D Will do now!
Checked with:
SELECT v_application_id, v_id
FROM zk_data.version
WHERE v_id NOT SIMILAR TO '[A-Za-z0-9]+([._-][A-Za-z0-9]+)*';
...and found one version, but this looks like a typo.
👏 for the tests!
👍
👍
Currently KIO accepts versions like
1...0
and0...---...0
.I think it is not good and we should validate the versions properly. This PR changes the regex that we use to validate. Although I am not sure if that is a feature or a bug. Just in case, there you have a PR so we can discuss.