zalando-stups / mint-worker

The secret rotator and distributor for the STUPS ecosystem
http://stups.readthedocs.org/en/latest/components/mint.html
Other
9 stars 3 forks source link

Unwritable S3 buckets status can be overwritten #16

Closed prayerslayer closed 8 years ago

prayerslayer commented 8 years ago

Situation: An application was never synced and has badly configured mint buckets. Result: Mint worker writes two times to storage, first with increased s3_errors, second setting s3_errors back to zero.

This happens because we handle S3 errors in sync_app ourselves while we expect in run the subroutine to throw on anything S3 related. Thus the status from run overwrites the one from sync_app and s3_errors is never more than 1.