search

zalando-stups / pierone-cli

DEPRECATED: Convenient command line client for STUPS' Pier One Docker registry
http://docs.stups.io/en/latest/components/pierone.html#command-line-client
Other
10 stars 13 forks source link

#58 delete credsStore property in the config object loaded from config.json #61

Closed luisfarzati closed 7 years ago

luisfarzati commented 7 years ago

Fixes #58 -- still some work needed in order to properly test.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 84.185% when pulling bc4f97f25ac83c3272e0bd949d59ef3f7add1168 on luisfarzati:58-fix-credsstore-bug into 0afce92aedf654855ad35b90623410e6d6c261dd on zalando-stups:master.

Raffo commented 7 years ago

@hjacobs The problem with the test looks like is coming from pierone/api.py line 65 where we read from the local config instead of the temp file.

EDIT: we have an exception while trying to open the file in docker_login_with_token: 

Expecting value: line 1 column 1 (char 0)
/private/var/folders/rt/9fhb28kx613cf5439wv1f3d1395t1c/T/pytest-of-rdifazio/pytest-16/test_docker_login_with_credsst0/.docker/config.json
Raffo commented 7 years ago

Ok I figured out the problem, pushed a commit with @luisfarzati , should work now!

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 84.428% when pulling 2b8aa9d20c68984ea9af219f085e15182c5799d0 on luisfarzati:58-fix-credsstore-bug into 0afce92aedf654855ad35b90623410e6d6c261dd on zalando-stups:master.

Raffo commented 7 years ago

@hjacobs please review.

luisfarzati commented 7 years ago

ty @Raffo :)

hjacobs commented 7 years ago

:+1: