zalando-stups / pierone-cli

DEPRECATED: Convenient command line client for STUPS' Pier One Docker registry
http://docs.stups.io/en/latest/components/pierone.html#command-line-client
Other
10 stars 13 forks source link

Older versions of docker do not parse the credential helpers correctly #86

Closed zalando-andrewhowden-com closed 4 years ago

zalando-andrewhowden-com commented 4 years ago

With a recent update to the pierone CLI older versions of docker on Ubuntu 18.04 appear to have broken with the login generated by pierone:

pierone login
$ docker --version
Docker version 18.06.1-ce, build e68fc7a

When attempting to pull the image they yield the following error:

$ docker pull pierone.fqdn/foo/bar:latest
Error response from daemon: Get https://pierone.fqdn/v2/foo/bar/manifests/latest: no basic auth credentials

This was discovered with the version of docker paged in snap. It is known that docker 19.03 works as expected:

# Output redacted
 $ docker pull pierone.fqdn/foo/bar:latest
latest: Pulling from foo/bar:latest
Digest: sha256:0396e1f8343aadf8b250e5a44a107af7162b1fd65fa14a42a9fbc2612d8efce5
Status: Image is up to date for pierone.fqdn/foo/bar:latest
pierone.fqdn/foo/bar:latest
$ docker version
Client: Docker Engine - Community
 Version:           19.03.4

I would conjecture the issue was introduced here:

https://github.com/zalando-stups/pierone-cli/commit/5538128ea049746f5f82f1a867d861155cf98984