zalando-stups / planb-provider

Plan B OpenID Connect Provider issuing JWT tokens
http://planb.readthedocs.org/
Other
16 stars 11 forks source link

Add logo field for the client #96

Closed artdaw closed 8 years ago

artdaw commented 8 years ago

We need a string field to store base64 encoded image.

hjacobs commented 8 years ago

Sounds reasonable, we should discuss whether we add individual Cassandra columns for the logo image and homepage URL (which also makes sense to have).

hjacobs commented 8 years ago

I would propose adding two fields to the client table:

hjacobs commented 8 years ago

I'm not sure whether storing base64-encoded image data in Cassandra is such a great idea..

artdaw commented 8 years ago

@hjacobs well, we just want to avoid security errors in case of publicly available images

harti2006 commented 8 years ago

Actually I like hjacobs idea of "Data URIs" in your case: https://en.wikipedia.org/wiki/Data_URI_scheme

@artdaw would that be feasible for you?

matosf commented 8 years ago

The base64 encoded image we where talking about is the Data URI with Base64 encoded image data that hjacobs better explained, so yes @harti2006, that is OK for us.

vroldanbet commented 8 years ago

+1 to Data URI :)