search

zalando-stups / play-zhewbacca

Play! framework library to protect REST endpoint by OAuth2 token verification - THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED
MIT License
22 stars 13 forks source link

Retry requests #19

Closed raychenon closed 7 years ago

raychenon commented 7 years ago

Retry failed requests in case of network / remote server failures. https://github.com/zalando-incubator/play-zhewbacca/issues/16

Note : The number of attempts and backoff duration variables need to be extracted in .conf file .

LappleApple commented 7 years ago

@raychenon Are you guys planning on merging this PR after resolving the conflict?

raychenon commented 7 years ago

@LappleApple , thanks for the reminder. Conflict resolved. We plan to merge this PR this week.

codecov-io commented 7 years ago

Codecov Report

Merging #19 into master will decrease coverage by -0.9%. The diff coverage is 84.61%.

@@            Coverage Diff            @@
##           master      #19     +/-   ##
=========================================
- Coverage   93.75%   92.85%   -0.9%     
=========================================
  Files          12       12             
  Lines         128      140     +12     
  Branches        7        5      -2     
=========================================
+ Hits          120      130     +10     
- Misses          8       10      +2
Impacted Files Coverage Δ
...c/main/scala/org/zalando/zhewbacca/IAMClient.scala 80% <84.61%> (+1.21%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1dd0a36...30f83b2. Read the comment docs.

dmitrykrivaltsevich commented 7 years ago

@raychenon , could you please release 0.2.2?

raychenon commented 7 years ago

@dmitrykrivaltsevich , I will release tomorrow . My machine is at work.

dmitrykrivaltsevich commented 7 years ago
dmitrykrivaltsevich commented 7 years ago

@raychenon , was 0.2.2 already released?