Improved error messaging when dealing with scopes

zalando-stups / play-zhewbacca

Play! framework library to protect REST endpoint by OAuth2 token verification - THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED

MIT License

22 stars 13 forks source link

Improved error messaging when dealing with scopes #20

Closed mdedetrich closed 7 years ago

mdedetrich commented 7 years ago

Committing this because we are currently trying to debug an application in production that this will be very useful for us.

This shouldn't have any security implications since we are just logging the token type and its scopes as extra info

codecov-io commented 7 years ago

Current coverage is 93.75% (diff: 50.00%)

Merging #20 into master will decrease coverage by 0.73%

@@             master        #20   diff @@
==========================================
  Files            12         12          
  Lines           127        128     +1   
  Methods         120        121     +1   
  Messages          0          0          
  Branches          7          7          
==========================================
  Hits            120        120          
- Misses            7          8     +1   
  Partials          0          0

Powered by Codecov. Last update d082413...53deffa

raychenon commented 7 years ago

@mdedetrich , thanks for the PR, we're checking the compatibility with internal apps.