search

zalando-stups / play-zhewbacca

Play! framework library to protect REST endpoint by OAuth2 token verification - THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED
MIT License
22 stars 13 forks source link

wrong DevModule example in readme file #3

Closed wokuyama closed 8 years ago

wokuyama commented 8 years ago 
import com.google.inject.AbstractModule
import org.zalando.zhewbacca._
import org.zalando.zhewbacca.metrics.{NoOpPlugableMetrics, PlugableMetrics}

class DevModule extends AbstractModule {

  override def configure(): Unit = {
    bind(classOf[PlugableMetrics]).to(classOf[NoOpPlugableMetrics])
    bind(classOf[AuthProvider]).to(classOf[AlwaysPassAuthProvider])
  }

}

should be:

import com.google.inject.AbstractModule
import org.zalando.zhewbacca._
import org.zalando.zhewbacca.metrics.{NoOpPlugableMetrics, PlugableMetrics}

class DevModule extends AbstractModule {
  val TestTokenInfo = TokenInfo("", Scope.Default, "token type", "user uid")
  override def configure(): Unit = {
    bind(classOf[PlugableMetrics]).to(classOf[NoOpPlugableMetrics])
    bind(classOf[AuthProvider]).toInstance(new AlwaysPassAuthProvider(TestTokenInfo))
  }

}
dmitrykrivaltsevich commented 8 years ago

@wokuyama , you can edit README right here and make PR

dmitrykrivaltsevich commented 8 years ago

@czare1 , could you please add @wokuyama to "stt" team? I don't have enough permissions to do this

dmitrykrivaltsevich commented 8 years ago

4