search

zalando-stups / play-zhewbacca

Play! framework library to protect REST endpoint by OAuth2 token verification - THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED
MIT License
22 stars 13 forks source link

Upgrade to Play Framework 2.6.3 and Scala 2.12.3 #36

Closed matterche closed 6 years ago

matterche commented 6 years ago

Fixes #35

Upgrade to Play Framework 2.6.3 and Scala 2.12.3. Most of the deprecation warnings are fixed. See PR comments.

codecov-io commented 6 years ago

Codecov Report

Merging #36 into master will increase coverage by 3.75%. The diff coverage is 94.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage    92.9%   96.66%   +3.75%     
==========================================
  Files          12       12              
  Lines         141      120      -21     
  Branches        6        6              
==========================================
- Hits          131      116      -15     
+ Misses         10        4       -6
Impacted Files Coverage Δ
...ala/org/zalando/zhewbacca/OAuth2AuthProvider.scala 100% <ø> (+10%) :arrow_up:
...n/scala/org/zalando/zhewbacca/SecurityFilter.scala 100% <ø> (ø) :arrow_up:
...scala/org/zalando/zhewbacca/RequestValidator.scala 100% <ø> (ø) :arrow_up:
...ain/scala/org/zalando/zhewbacca/SecurityRule.scala 100% <ø> (ø) :arrow_up:
...ala/org/zalando/zhewbacca/TokenInfoConverter.scala 100% <100%> (ø) :arrow_up:
...c/main/scala/org/zalando/zhewbacca/TokenInfo.scala 100% <100%> (ø) :arrow_up:
...rg/zalando/zhewbacca/SecurityRulesRepository.scala 100% <100%> (ø) :arrow_up:
...c/main/scala/org/zalando/zhewbacca/IAMClient.scala 87.5% <88.88%> (+7.5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b74e81...d15d17f. Read the comment docs.

matterche commented 6 years ago

@dmitrykrivaltsevich What do you think about merging the PR and release a new version? What needs to be fixed from your point of view? I currently have the problem that I need a new version to push the migration of our services and I don't want to release a SNAPSHOT version 😉

dmitrykrivaltsevich commented 6 years ago

I didn't manage to catch the reason why the test fails, so I'll write a small app tomorrow and I will check how the library works when auth server is super slow. I'm still not sure what is broken -- the test (most likely) or the code. If it is a test, then I will release a new version tomorrow.

matterche commented 6 years ago

The tests really fail? I never experienced failing tests neither on my local machine nor on Travis. They just slowed down because of the Thread.sleep.

dmitrykrivaltsevich commented 6 years ago

I spent few days on it and still in doubts, but I think it's better to release a new version now and investigate this later. Thank you again for the contribution and sorry for the delay.

matterche commented 6 years ago

No problem, I'm happy to help. Thanks for taking care of the release!

dmitrykrivaltsevich commented 6 years ago

Released in version 0.3.1