search

zalando-stups / play-zhewbacca

Play! framework library to protect REST endpoint by OAuth2 token verification - THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED
MIT License
22 stars 13 forks source link

How does this work with play's default compile time DI #8

Open i-am-the-slime opened 8 years ago

i-am-the-slime commented 8 years ago

Guice seems to not be preferred anymore https://www.playframework.com/documentation/2.5.x/ScalaCompileTimeDependencyInjection. There are rumours that it is goto's little brother and it has been seen playing with var.

How do we get around it?

LappleApple commented 8 years ago

Hi @i-am-the-slime -- has someone answered your question yet (maybe on HipChat or in person)?

i-am-the-slime commented 8 years ago

Nope, not yet. But thanks for getting back to me, @LappleApple !

dmitrykrivaltsevich commented 7 years ago

@i-am-the-slime , in our play projects we use runtime DI, so we have no needs in compile-time DI. From other side if this will increase adoption of the library then PR is more than welcome!

raychenon commented 7 years ago

@i-am-the-slime , compile-time DI makes app startup time faster. A web app is rarely restarted unlike a mobile app. Use of runtime DI has no performance impact on the web service. On the other hand, if runtime DI get widely adopted , then a PR is welcome.