Fixes up implicit parameter lists

zalando-stups / play-zhewbacca

Play! framework library to protect REST endpoint by OAuth2 token verification - THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED

MIT License

22 stars 13 forks source link

Fixes up implicit parameter lists #9

Closed mdedetrich closed 7 years ago

mdedetrich commented 8 years ago

Zhewbacca didn't curry implicit parameter lists, its often idiomatic to curry implicit lists as thats what allows you to pass in in implicits automatically

Although this makes no difference for dependency injection for the typical way (using Guice), if you need to manually hardwire your SecurityFilter it makes it a lot easier since there are fewer parameters that you need to provide (in this case, ExecutionContext and Materializer can be skipped by marking them as implicit)

LappleApple commented 7 years ago

@dmitrykrivaltsevich Hey Dmitry, any plan to review this PR and merge? It's been here for a while. cc @mdedetrich

dmitrykrivaltsevich commented 7 years ago

@LappleApple Hi Lauri, most likely this will happen during HackWeek

LappleApple commented 7 years ago

@dmitrykrivaltsevich hmmm, looks like it didn't get merged. Now there's a conflict. @mdedetrich, what are your thoughts?

dmitrykrivaltsevich commented 7 years ago

I'm closing this PR because it's stale.