zalando-stups / put-it-to-rest

https://github.com/zalando/riptide/tree/master/riptide-spring-boot-starter
MIT License
11 stars 6 forks source link

Fix HttpMessageConverters registration #21

Closed lukasniemeier-zalando closed 8 years ago

lukasniemeier-zalando commented 8 years ago

It seems like the configuration for HttpMessageConverters is ignored.

(...)
public final class ClientConfigurationTest {
   (...)

    @Test
    public void shouldRegisterOnlyRegisteredConverters() {
        final List<HttpMessageConverter<?>> converters = ecbRestTemplate.getMessageConverters();
        assertThat(converters, hasSize(2));  // fails because never overwritten
    }
}
whiskeysierra commented 8 years ago

That's weird. I'm using this in production already. At least I thought I was. Can you create a failing unit test?

lukasniemeier-zalando commented 8 years ago

See #22 - I assume this is the expected behavior.

How can you use this library in production if majorVersion < 1?!?! /s

whiskeysierra commented 8 years ago

How can you use this library in production if majorVersion < 1?!?! /s

We do it live

lukasniemeier-zalando commented 8 years ago

That's the spirit :godmode: