search

zalando-stups / senza

Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way
https://pypi.python.org/pypi/stups-senza
Other
96 stars 72 forks source link

Fix TCP mode for the ELB component by using a correct health check #483

Closed sarnowski closed 7 years ago

sarnowski commented 7 years ago

HTTP and HTTPS have HTTP(S):<port><path> target syntax but TCP does not know about paths: TCP:<port>.

See here: http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-elb-health-check.html#cfn-elb-healthcheck-target

sarnowski commented 7 years ago

👍

hjacobs commented 7 years ago

Can you fix indent? Thanks!

sarnowski commented 7 years ago

👍 done

sarnowski commented 7 years ago

👍

jmcs commented 7 years ago

One test is still failing.

hjacobs commented 7 years ago

@sarnowski can you fix the test please? It seems to be related to your change...

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.006%) to 89.622% when pulling a1a618045411427907e1700aab64430c2864621d on fix-tcp-elb-support into 1471a312e4487cb3e72be209d623a9f99f58f06f on master.

sarnowski commented 7 years ago

Fixed the wrong assertion in the unit test.

sarnowski commented 7 years ago

👍

hjacobs commented 7 years ago

:+1: