search

zalando-stups / senza

Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way
https://pypi.python.org/pypi/stups-senza
Other
96 stars 72 forks source link

#493: Support ClusterName for RedisNode component #494

Closed inikolaev closed 5 years ago

inikolaev commented 6 years ago

This PR adds support for ClusterName property which can be used inside RedisNode component definition in order to specify the name of the Redis cluster. If ClusterName is not provided the name of the definition will be used instead.

inikolaev commented 6 years ago

@hjacobs Do you have time to take a look? It's a one line change.

hjacobs commented 6 years ago

I wonder whether the Senza Redis component still makes sense? It's rather easy to do it with pure Cloud Formation (Resources top level key in Senza file).

hjacobs commented 6 years ago

:+1:

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 89.636% when pulling 1f29b20ad48e65c15bae645d1efc3cbc5cdd053b on inikolaev:493-support-redis-cluster-name into d35c8e5d8e48e0586f182cc0ffba649bf9adcf4a on zalando-stups:master.

inikolaev commented 6 years ago

True, but since it still exists :)

inikolaev commented 6 years ago

@hjacobs The build for Python 3.5 fails with: ERROR: InvocationError: '/home/travis/build/zalando-stups/senza/.tox/flake8/bin/python setup.py flake8' Wonder if it's important or it's a known problem?

inikolaev commented 6 years ago

👍