zalando-stups / senza

Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way
https://pypi.python.org/pypi/stups-senza
Other
96 stars 72 forks source link

fix senza not to put NAT subnets into server subnets #495

Closed szuecs closed 6 years ago

szuecs commented 6 years ago

NAT gateways created by https://github.com/szuecs/kube-static-egress-controller/ will also get a new subnet, because servers could be placed in dmz or private subnets and both has to be routed for given static egress targets.

Senza will normally find these NAT subnets and place ELB interfaces into them, which create failures at runtime.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.02%) to 89.615% when pulling 1b71dc89f627b7f5cf9bc90e663ee60811e864f2 on szuecs:ignore/nat-subnets into d35c8e5d8e48e0586f182cc0ffba649bf9adcf4a on zalando-stups:master.

jmcs commented 6 years ago

👍

szuecs commented 6 years ago

:+1: