#504: Add Support for Spotinst Elastigroup Component

zalando-stups / senza

Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way

https://pypi.python.org/pypi/stups-senza

Other

96 stars 72 forks source link

#504: Add Support for Spotinst Elastigroup Component #504

Closed danieldop closed 6 years ago

danieldop commented 6 years ago

This PR fixes: https://github.com/zalando-stups/senza/issues/506

coveralls commented 6 years ago

Coverage remained the same at 89.575% when pulling 6dfef4320c553d625b1cdd2af793feb878275989 on spotinst:master into fff8cf69b43f5ed958d1d8c960179c590114a885 on zalando-stups:master.

lmineiro commented 6 years ago

Just to be sure, this would also work when using the SpotInst on-premise appliance, right?

femueller commented 6 years ago

@danieldop Not a Senza expert myself, but from what I can see it looks good to me. I'd first recommend to add the docstrings for now.

@jmcs @tuxlife Can you add your 2 cents, please?

jmcs commented 6 years ago

Hi, please fill out the pull request description and had some documentation to your functions.

jmcs commented 6 years ago

Please also fill out the PR description.

jmcs commented 6 years ago

:+1:

danieldop commented 6 years ago

Anything missing?

femueller commented 6 years ago

@danieldop I did the missing changes and it looks good to me too now @jmcs Can we merge it now?

femueller commented 6 years ago

👍