search

zalando-stups / senza

Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way
https://pypi.python.org/pypi/stups-senza
Other
96 stars 72 forks source link

Disable InstanceMonitoring for LaunchConfiguration if needed #508

Closed mnatsakanyank closed 6 years ago

mnatsakanyank commented 6 years ago

There should be a way to disable InstanceMonitoring if its not needed for LaunchConfiguration

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 89.555% when pulling cd46d61b039ef34b82e8a1eabb44590224c5478d on mnatsakanyank:patch-1 into 6c4b9c8e28d5d0189ae6064bb0964fe2446b1d86 on zalando-stups:master.

mnatsakanyank commented 6 years ago

@hjacobs @jmcs Guys can you please take a look on this pull request, this will allow us to reduce costs by 30%. Thanks.

jmcs commented 6 years ago

:+1:

hjacobs commented 6 years ago

For reference: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-launchconfig.html#cfn-as-launchconfig-instancemonitoring

hjacobs commented 6 years ago

:+1:

mnatsakanyank commented 6 years ago

@hjacobs @jmcs Thanks for approval. Do you maybe know an upcoming release date?