Closed lmineiro closed 6 years ago
:+1:
:+1:
Thanks again @talzur
spotinst/components/elastigroup.py:361 - Perhaps you would want to use two kinds of defaults here
This was an oversight. The API clearly shows those different healthcheck types. Created #519 for tracking.
spotinst/components/elastigroup.py:444-448 If I am not mistaken the code here can lead to a situation where you do not set up an OD type.
This was yet another oversight. We thought the On Demand was actually optional and programmed it according to that assumption. Thanks for confirming that's not the case. Created #520 for tracking.
This should bring Spotinst's Elastigroup to feature parity with native AWS Auto Scaling Groups.
It also changes the syntax to reuse all of the ASG settings while allowing the more advanced Elastigroup API definition, which takes precedence whenever defined.
/cc @jmcs @danieldop