search

zalando-stups / senza

Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way
https://pypi.python.org/pypi/stups-senza
Other
96 stars 72 forks source link

added missing functionality to elastigroup #516

Closed lmineiro closed 6 years ago

lmineiro commented 6 years ago

This should bring Spotinst's Elastigroup to feature parity with native AWS Auto Scaling Groups.

It also changes the syntax to reuse all of the ASG settings while allowing the more advanced Elastigroup API definition, which takes precedence whenever defined.

/cc @jmcs @danieldop

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.008%) to 89.549% when pulling 526235b6c29c852585027ada35a91f3e28fd0078 on lmineiro:elastigroup-feature-parity into b873d14a461a25fbdc4779b942b3c7dc4763d4cf on zalando-stups:master.

jmcs commented 6 years ago

:+1:

lmineiro commented 6 years ago

:+1:

lmineiro commented 6 years ago

Thanks again @talzur

spotinst/components/elastigroup.py:361 - Perhaps you would want to use two kinds of defaults here

This was an oversight. The API clearly shows those different healthcheck types. Created #519 for tracking.

spotinst/components/elastigroup.py:444-448 If I am not mistaken the code here can lead to a situation where you do not set up an OD type.

This was yet another oversight. We thought the On Demand was actually optional and programmed it according to that assumption. Thanks for confirming that's not the case. Created #520 for tracking.