search

zalando-stups / senza

Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way
https://pypi.python.org/pypi/stups-senza
Other
96 stars 71 forks source link

added support for the TargetGroupARNs property in Elastigroups #536

Closed lmineiro closed 5 years ago

lmineiro commented 5 years ago

The native AutoScalingGroup allowed a subset of CloudFormation properties to be set directly

Some of the keys don't make sense/are not usable with Elastigroups: TerminationPolicies and MetricsCollection.

The PlacementGroup is supported by the Elastigroup and should be addressed separately.

This change adds support for the TargetGroupARNs property. When present, they will be set as the Elastigroup's loadBalancers. The default TargetGroup is still created by the ElasticLoadBalancerV2 component for backward compatibility but not used/referred by the Elastigroup.

/cc @pc-alves @jmcs

jmcs commented 5 years ago

:+1:

lmineiro commented 5 years ago

:+1: