zalando-stups / senza

Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way
https://pypi.python.org/pypi/stups-senza
Other
96 stars 72 forks source link

fixed the user data encoding by using the proper base64 #541

Closed lmineiro closed 6 years ago

lmineiro commented 6 years ago

The function base64.urlsafe_b64encode() would fail to properly encode the > character, as stated in #540

That affected the Elastigroup creation whenever the > was present in the user data.

For the CloudFormation template the fix was to use the same deferred call to Fn::Base64, just like for the native Auto Scaling Groups.

The patch command was changed to use the correct base64.b64encode() function.

pc-alves commented 6 years ago

👍

jmcs commented 6 years ago

:+1: