Always add standard STUPS EC2 tags

zalando-stups / senza

Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way

https://pypi.python.org/pypi/stups-senza

Other

96 stars 71 forks source link

Always add standard STUPS EC2 tags #553

Closed inikolaev closed 5 years ago

inikolaev commented 5 years ago

This PR makes changes to the way standard STUPS tags specified within ElastiGroup component are handled:

Standard tags are always added to the list of tags even in the presence of custom tags
Any standard tags specified in configuration are overridden by values from Senza definition - I have never ever had to specify these tags manually, so please let me know if you think there's a valid use case when it might be useful to actually override tags and I will change the logic

lmineiro commented 5 years ago

:+1:

lmineiro commented 5 years ago

fyi, not setting the tags whenever the property was present was a deliberate decision to stay consistent. The behavior for the remaining properties is also to leave them untouched if present in the definition. The reasoning for that is that it's possible to set them if wanted but also possible NOT to set them. With your proposal, it will no longer be possible NOT to set them.

I think that's still reasonable as the general behavior of Senza when using native ASGs is to set them

inikolaev commented 5 years ago

@lmineiro so, should we set them as per this PR? I'm confused :) I could add some boolean property which would be used to disable this, but default would be to always set STUPS tags.

pc-alves commented 5 years ago

👍