Fix testing pipeline - Githubissues

zalando-stups / senza

Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way

https://pypi.python.org/pypi/stups-senza

Other

96 stars 72 forks source link

Fix testing pipeline #580

Closed hughcapet closed 1 year ago

hughcapet commented 1 year ago

CDP overlays -> runtime
Remove top-level region option
Define a separate Command class for flake8 in setup.py (flake8 setuptools/setup.py support is now deprecated)
Fix a flake8 error

Jan-M commented 1 year ago

:+1:

jmcs commented 1 year ago

LGTM but I've a question. Why are you removing the top-level region option?

hughcapet commented 1 year ago

@jmcs

sorry, should have posted the message from one of the commits. This is because this was causing the following misbehavior (revealed in the test_cli.py unit tests):

The current implementation uses value set via the envvar AWS_DEFAULT_REGION
for sub-commands even if an explicit flag value is provided.

And I actually don't fully understand the whole idea of having the top-level region option.

hughcapet commented 1 year ago

👍