search

zalando-stups / sevenseconds

THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED
https://pypi.python.org/pypi/stups-sevenseconds
Other
66 stars 17 forks source link

Add option to disable odd per account #105

Closed jonathanbeber closed 3 years ago

jonathanbeber commented 3 years ago

With more accounts in Kubernetes and other soltions like EC2 Instance Connect odd hosts are not needed. This commit creates the enable_odd config that defaults to True and enable us to disable this feature per account. If odd instances are found and it's disabled it will be removed while in new accounts it won't be created.

aermakov-zalando commented 3 years ago

Would you mind incrementing SUPPORTED_CONFIG_VERSION in cli.py? This will ensure that the users don't forget to update 7s.

aermakov-zalando commented 3 years ago

Otherwise LGTM.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.06%) to 24.318% when pulling 7d58b031bb7e2d90029e8484fa02b00c2f603dcb on odd into 85fa405dfd161a6f71516f433e2babfccf40cf35 on master.

jonathanbeber commented 3 years ago

thanks, @aermakov-zalando, just did!

jonathanbeber commented 3 years ago

:+1:

aermakov-zalando commented 3 years ago

👍