zalando-stups / sevenseconds

THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED
https://pypi.python.org/pypi/stups-sevenseconds
Other
66 stars 17 forks source link

clear: Cleanup KMS VPC endpoint #106

Closed mikkeloscar closed 3 years ago

mikkeloscar commented 3 years ago

Support for provisioning a KMS VPC endpoint was added in #102

This implements the cleanup so it's cleanly deleted before the VPC when running 7s clear.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.07%) to 24.248% when pulling 20fadfc0c7241e85b64f561f8fc0086844de50b3 on cleanup-kms-endpoint into ffc8973faac2ab36a649e6ebb54ec6e50a999d79 on master.

codecov-io commented 3 years ago

Codecov Report

Merging #106 (20fadfc) into master (ffc8973) will decrease coverage by 0.06%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   24.31%   24.24%   -0.07%     
==========================================
  Files          25       25              
  Lines        2089     2095       +6     
==========================================
  Hits          508      508              
- Misses       1581     1587       +6     
Impacted Files Coverage Δ
sevenseconds/config/vpc.py 7.42% <0.00%> (-0.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffc8973...20fadfc. Read the comment docs.

jonathanbeber commented 3 years ago

:+1:

mikkeloscar commented 3 years ago

:+1: