Closed mikkeloscar closed 3 years ago
Merging #112 (1846777) into master (bc3ee9b) will decrease coverage by
0.04%
. The diff coverage is10.00%
.
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 24.50% 24.45% -0.05%
==========================================
Files 25 25
Lines 2110 2114 +4
==========================================
Hits 517 517
- Misses 1593 1597 +4
Impacted Files | Coverage Δ | |
---|---|---|
sevenseconds/config/configure.py | 26.47% <0.00%> (ø) |
|
sevenseconds/config/cloudwatch.py | 9.09% <11.11%> (-5.20%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bc3ee9b...1846777. Read the comment docs.
Docker image "pierone.stups.zalan.do/teapot/sevenseconds-release-pr:112" is not based on an approved base image. Any production deployment relying on this image will be blocked.
To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Open Source Registry namespace library
and use a recommended version as listed in the documentation.
👍
:+1:
Add support for setting a retention time on the log group used for vpc flow logs.
If nothing is specified in the config file it will default to
3653
days (10 years) which is the highest retention in days if you don't specify never expire which was the default for us so far.The idea would be to set this to a lower value as per our internal requirements.