use custom names for custom subnets

zalando-stups / sevenseconds

THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED

https://pypi.python.org/pypi/stups-sevenseconds

Other

66 stars 17 forks source link

use custom names for custom subnets #113

Closed aryszka closed 3 years ago

aryszka commented 3 years ago

Signed-off-by: Arpad Ryszka arpad.ryszka@gmail.com

aermakov-zalando commented 3 years ago

👍

aermakov-zalando commented 3 years ago

LGTM, although I'd consider what happens if someone runs an older version of 7s. Would the subnet be deleted/tags broken? You might want to bump the minimum config version just in case.

aryszka commented 3 years ago

:+1:

elgalu commented 3 years ago

👍🏽

aryszka commented 3 years ago

:+1:

jonathanbeber commented 3 years ago

:+1: