Closed ideahitme closed 7 years ago
@tuxlife I already reviewed, maybe you want to at it, too. :+1:
Merging #65 into master will decrease coverage by
2.06%
. The diff coverage is12.12%
.
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 24.5% 22.44% -2.07%
==========================================
Files 23 24 +1
Lines 2179 2139 -40
==========================================
- Hits 534 480 -54
- Misses 1645 1659 +14
Impacted Files | Coverage Δ | |
---|---|---|
sevenseconds/config/__init__.py | 29.91% <50%> (+0.34%) |
:arrow_up: |
sevenseconds/config/kms.py | 9.67% <9.67%> (ø) |
|
sevenseconds/helper/__init__.py | 100% <0%> (+19.73%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8a3c760...1967682. Read the comment docs.
@tuxlife I made quite a few changes, please take a look again (change the configuration.yaml as well)
:+1:
@tuxlife please take a look again
:+1:
Please use squash merge
👍
This PR adds kms key for each account if specified in the configuration. It also allows to update the policy when key_alias already there. See our configuration for the pattern we will use:
/cc @tuxlife @szuecs