zalando-stups / sevenseconds

THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED
https://pypi.python.org/pypi/stups-sevenseconds
Other
66 stars 17 forks source link

support dropping kms-keys #67

Closed ideahitme closed 7 years ago

ideahitme commented 7 years ago

/cc @tuxlife @mikkeloscar

Support dropping kms-key, added TODO as well

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 24.274% when pulling d79732941b1c5b11e8dbf35aca65286d8966246a on clean-up/deployment-kms-role into a6f8889ebfaaeb55727ea863ac29aaa3d7755754 on master.

codecov-io commented 7 years ago

Codecov Report

Merging #67 into master will decrease coverage by 0.12%. The diff coverage is 9.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   22.44%   22.31%   -0.13%     
==========================================
  Files          24       24              
  Lines        2139     2160      +21     
==========================================
+ Hits          480      482       +2     
- Misses       1659     1678      +19
Impacted Files Coverage Δ
sevenseconds/config/kms.py 9.61% <9.52%> (-0.07%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6f8889...a20b2f0. Read the comment docs.

ideahitme commented 7 years ago

@tuxlife changed, please look again

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 24.284% when pulling e68bbcf0410824bc5498c8eed03b1ec7225fafae on clean-up/deployment-kms-role into a6f8889ebfaaeb55727ea863ac29aaa3d7755754 on master.

tuxlife commented 7 years ago

@ideahitme please replace the rest of the new keys with lowercase name with underscore

KeyUsage -> key_usage KeyPolicy -> key_policy

ideahitme commented 7 years ago

@tuxlife done

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 24.284% when pulling 6516f4888a0d887389289bea1bf52af00c71c22f on clean-up/deployment-kms-role into a6f8889ebfaaeb55727ea863ac29aaa3d7755754 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 24.284% when pulling a20b2f06960434c4ff9cf7ba6f52350c5a464e20 on clean-up/deployment-kms-role into a6f8889ebfaaeb55727ea863ac29aaa3d7755754 on master.

tuxlife commented 7 years ago

:+1:

ideahitme commented 7 years ago

👍