search

zalando-stups / sevenseconds

THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED
https://pypi.python.org/pypi/stups-sevenseconds
Other
66 stars 17 forks source link

check if NotAfter key is present before proceeding to cert renewal #69

Closed ideahitme closed 7 years ago

ideahitme commented 7 years ago

DO NOT MERGE YET

/cc @tuxlife please have a look

tuxlife commented 7 years ago

:+1:

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 24.149% when pulling 37ed81631ee980d24e9629ca07563614f55a762a on fix/check-acm-response into f772683926a8a8077007ed410c883ed6c89efb49 on master.

codecov-io commented 7 years ago

Codecov Report

Merging #69 into master will decrease coverage by 0.41%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   22.19%   21.78%   -0.42%     
==========================================
  Files          24       24              
  Lines        2185     2291     +106     
==========================================
+ Hits          485      499      +14     
- Misses       1700     1792      +92
Impacted Files Coverage Δ
sevenseconds/config/acm.py 8.69% <0%> (ø) :arrow_up:
sevenseconds/config/vpc.py 8.16% <0%> (+1.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f772683...37ed816. Read the comment docs.

ideahitme commented 7 years ago

👍