aermakov-zalando commented 6 years ago

config.base_ami: rename name to default_channel, add an optional channels list
only the latest base AMI is configured for each region and channel
list of latest base AMIs is prepared once and then reused across all accounts to avoid rate limit issues. per-account overrides are thus unsupported, but I don't think they make a lot of sense
dropped an unused configure_bastion_host_deprecated function

aermakov-zalando commented 6 years ago

@tuxlife asked to move the Taupage sharing logic from sevenseconds to aws-account-creator, so I'm closing this.

aermakov-zalando commented 6 years ago

Let's discuss this again. I've had a look at the aws-account-creator code and right now it does absolutely nothing other than creating the account and then running sevenseconds several times to actually initialise it. While I agree that it might make sense to move most of the logic there, I think it should be done as part of a separate issue, not as part of changing one part of the logic.

szuecs commented 6 years ago

@tuxlife for me this looks good and as discussed in our meeting, it's a change from the old share based model to a channel based, that works pretty fine in our cluster setup. I think in general it makes a lot of sense. I also think it makes sense that this change lives in sevenseconds. Maybe we have to define the scope from our internal tool and sevenseconds, such that it is more clear what to do where. From my side lgtm

codecov-io commented 6 years ago

Codecov Report

Merging #75 into master will increase coverage by 0.5%. The diff coverage is 18.57%.

@@            Coverage Diff            @@
##           master      #75     +/-   ##
=========================================
+ Coverage   24.02%   24.52%   +0.5%     
=========================================
  Files          23       23             
  Lines        2256     2385    +129     
=========================================
+ Hits          542      585     +43     
- Misses       1714     1800     +86

Impacted Files	Coverage Δ
sevenseconds/cli.py	`60.12% <0%> (-1.67%)`	:arrow_down:
sevenseconds/config/vpc.py	`7.8% <100%> (+0.88%)`	:arrow_up:
sevenseconds/config/bastion.py	`8.82% <12.5%> (+1.61%)`	:arrow_up:
sevenseconds/config/ami.py	`16.66% <17.24%> (+5.79%)`	:arrow_up:
sevenseconds/config/__init__.py	`27.2% <20.68%> (-2.11%)`	:arrow_down:
sevenseconds/helper/network.py	`35% <0%> (+3.88%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 246f303...795f2be. Read the comment docs.

coveralls commented 6 years ago

Coverage increased (+0.8%) to 24.966% when pulling 795f2be1c26821b315e0ac3bf2638c486066aee6 on taupage-channels into 246f303aa2f338aeb4a229a691b4cd75986c4551 on master.

aermakov-zalando commented 6 years ago

👍

mikkeloscar commented 6 years ago

:+1:

zalando-stups / sevenseconds

Support multiple base AMI channels #75

Codecov Report