search

zalando-stups / sevenseconds

THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED
https://pypi.python.org/pypi/stups-sevenseconds
Other
66 stars 17 forks source link

Raise exception when role is not found. #77

Closed arjunrn closed 5 years ago

arjunrn commented 6 years ago

Currently, when the the role cannot be found a None is returned which then is used in subsequent operations leading to confusing error messages. This fix instead raises and exception when the required role is not available to the user.

codecov-io commented 6 years ago

Codecov Report

Merging #77 into master will increase coverage by 2.72%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   22.13%   24.86%   +2.72%     
==========================================
  Files          22       23       +1     
  Lines        1938     2196     +258     
==========================================
+ Hits          429      546     +117     
- Misses       1509     1650     +141
Impacted Files Coverage Δ
sevenseconds/helper/auth.py 27.21% <0%> (ø) :arrow_up:
sevenseconds/_version.py 44.65% <0%> (ø)
sevenseconds/config/acm.py 10.71% <0%> (+0.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa1c918...9c8b277. Read the comment docs.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 24.966% when pulling e2a3236aee962ea896adf39831915d30413b111f on arjunrn:fix/exception-on-missing-role into 26d946ae5a425624e64127174f650e4bc735e8b3 on zalando-stups:master.

mikkeloscar commented 5 years ago

:+1:

arjunrn commented 5 years ago

:+1: