zalando-stups / sevenseconds

THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED
https://pypi.python.org/pypi/stups-sevenseconds
Other
66 stars 17 forks source link

Ignore certificates in PENDING_AUTO_RENEWAL #79

Closed aermakov-zalando closed 5 years ago

aermakov-zalando commented 5 years ago

ACM doesn't allow sending validation emails for certificates in PENDING_AUTO_RENEWAL, only PENDING_VALIDATION. Ignore those instead of failing.

codecov-io commented 5 years ago

Codecov Report

Merging #79 into master will decrease coverage by 0.04%. The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   24.86%   24.81%   -0.05%     
==========================================
  Files          23       23              
  Lines        2196     2200       +4     
==========================================
  Hits          546      546              
- Misses       1650     1654       +4
Impacted Files Coverage Δ
sevenseconds/config/acm.py 10% <0%> (-0.72%) :arrow_down:
sevenseconds/helper/aws.py 58.53% <100%> (ø) :arrow_up:
sevenseconds/config/route53.py 8.49% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26d946a...8dee87f. Read the comment docs.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.05%) to 24.921% when pulling 8dee87f11c0886a6bc0d20c376d2cfadcd16381f on pending-auto-renewal-certs into 26d946ae5a425624e64127174f650e4bc735e8b3 on master.

arjunrn commented 5 years ago

:+1:

aermakov-zalando commented 5 years ago

👍