search

zalando-stups / sevenseconds

THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED
https://pypi.python.org/pypi/stups-sevenseconds
Other
66 stars 17 forks source link

Enhance S3 Bucket Creation #82

Closed christianberg closed 5 years ago

christianberg commented 5 years ago

This PR allows to configure the following attributes for the created S3 buckets:

szuecs commented 5 years ago

@christianberg please fix the travis errors, thanks

Code looks ok to me

codecov-io commented 5 years ago

Codecov Report

Merging #82 into master will increase coverage by 1.55%. The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   22.13%   23.69%   +1.55%     
==========================================
  Files          22       22              
  Lines        1938     1950      +12     
==========================================
+ Hits          429      462      +33     
+ Misses       1509     1488      -21
Impacted Files Coverage Δ
sevenseconds/config/s3.py 63.79% <94.11%> (+50.74%) :arrow_up:
sevenseconds/helper/__init__.py 82.89% <0%> (+2.63%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6e7174...cbba324. Read the comment docs.

christianberg commented 5 years ago

I'm sorry, I don't really understand this. I tried upgrading pytest, and now the build of the branch on Travis-CI passes, but the build of the PR fails.

Since the build was broken before my PR, maybe one of you can take a look?

mikkeloscar commented 5 years ago

@christianberg I'm having a look to fix it!

mikkeloscar commented 5 years ago

I'm just upgrading the version of python and then it works: https://github.com/zalando-stups/sevenseconds/pull/83 please rebase on master when this is merged!

mikkeloscar commented 5 years ago

@christianberg I rebased your PR on master, should work now!

coveralls commented 5 years ago

Coverage Status

Coverage increased (+1.6%) to 23.731% when pulling cbba324bb326eb807869d29eaff509b0879b4a8b on bucket-lifecycle-support into a6e7174f9a495cc579cb39e3621f650605a84449 on master.

christianberg commented 5 years ago

Thank you @mikkeloscar!

On 8. Feb 2019, at 16:14, Coveralls notifications@github.com wrote:

Coverage decreased (-0.03%) to 22.142% when pulling cf41dc3 on bucket-lifecycle-support into a6e7174 on master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

christianberg commented 5 years ago

I changed the scope of the PR and added more functionality (see updated title and description above).

njuettner commented 5 years ago

👍

gargravarr commented 5 years ago

:+1: