mikkeloscar commented 5 years ago

Instead of checking all regions with cloudtrail limit it to regions that we actually have used. This fixes an issue where we tried to check the region ap-east-1 which is disabled by default and therefore makes sevenseconds fail. This is the first region which is disabled by default in AWS, why we didn't see this issue before.

Depends on internal configuration PR.

coveralls commented 5 years ago

Coverage decreased (-0.02%) to 23.707% when pulling 7addda94ac63b52816341f037336ac3eb94ef3e0 on limit-cloudtrail-regions into ac879c11a72420d0e050ef98b6ff7856060d4ca1 on master.

mikkeloscar commented 5 years ago

:+1:

mikkeloscar commented 5 years ago

:+1:

aermakov-zalando commented 5 years ago

👍

codecov-io commented 5 years ago

Codecov Report

Merging #84 into master will decrease coverage by 0.02%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   23.69%   23.66%   -0.03%     
==========================================
  Files          22       22              
  Lines        1950     1952       +2     
==========================================
  Hits          462      462              
- Misses       1488     1490       +2

Impacted Files	Coverage Δ
sevenseconds/config/cloudtrail.py	`34.66% <0%> (-0.95%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac879c1...7addda9. Read the comment docs.

zalando-stups / sevenseconds

Only attempt to drop cloudtrail data from relevant regions #84

Codecov Report