Closed aermakov-zalando closed 5 years ago
Merging #86 into master will increase coverage by
0.23%
. The diff coverage is26.66%
.
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 23.66% 23.89% +0.23%
==========================================
Files 22 22
Lines 1952 1975 +23
==========================================
+ Hits 462 472 +10
- Misses 1490 1503 +13
Impacted Files | Coverage Δ | |
---|---|---|
sevenseconds/config/vpc.py | 7.37% <14.28%> (+0.64%) |
:arrow_up: |
sevenseconds/cli.py | 62.4% <70%> (+0.8%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e8d3a03...2da327d. Read the comment docs.
:+1:
👍
:+1:
If the vpc configuration contains a
subnets
key, don't configure the default subnets at all. Instead, read the list of subnets to be configured from that value. The value must be a dict where the keys are AZ names and the values are lists of subnet objects:To stop older versions of sevenseconds from completely destroying the account, VPC configuration is slightly changed (
network
is renamed tocidr
). This will cause an exception in the old version, but I'm open to other suggestions. There's also an explicit check for the configuration version so this won't be needed in the future.