Closed aermakov-zalando closed 5 years ago
Do I understand correctly that we need to specify the domain for all accounts now? Or do we just need to set domain: null
to opt out? In our big configuration file I mean.
@mikkeloscar no, it's inherited from the default configuration, we just opt out for individual accounts.
Merging #91 into master will increase coverage by
0.51%
. The diff coverage is37.14%
.
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 23.8% 24.31% +0.51%
==========================================
Files 23 24 +1
Lines 1983 2019 +36
==========================================
+ Hits 472 491 +19
- Misses 1511 1528 +17
Impacted Files | Coverage Δ | |
---|---|---|
sevenseconds/helper/auth.py | 26.58% <0%> (-0.64%) |
:arrow_down: |
sevenseconds/helper/network.py | 32.65% <0%> (-1.39%) |
:arrow_down: |
sevenseconds/cli.py | 63.49% <100%> (ø) |
:arrow_up: |
sevenseconds/config/configure.py | 26.47% <26.47%> (ø) |
|
sevenseconds/config/route53.py | 9% <30.76%> (+0.51%) |
:arrow_up: |
sevenseconds/config/bastion.py | 9.12% <54.54%> (+0.3%) |
:arrow_up: |
sevenseconds/config/iam.py | 7.75% <55.55%> (+0.55%) |
:arrow_up: |
sevenseconds/config/vpc.py | 7.54% <61.53%> (+0.16%) |
:arrow_up: |
sevenseconds/config/__init__.py | 85.71% <85%> (+58.17%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a75d407...710c239. Read the comment docs.
:+1:
👍
Found a bug for accounts with no opt out, please +1 again!
👍
:+1:
If
account.domain
is set tonull
, don't manage DNS for account. This will not create DNS records for NAT GWs, the bastion host, or try to manage the certificate.I tried improving the typing situation a bit (using proper types instead of
account: object
everywhere), which unfortunately necessitated moving stuff around to avoid circular imports. I didn't do a really good job at it, but I don't think this codebase can be improved incrementally.