search

zalando-stups / sevenseconds

THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED
https://pypi.python.org/pypi/stups-sevenseconds
Other
66 stars 17 forks source link

Add a enable_nat config item which creates NAT gateways #94

Closed arjunrn closed 4 years ago

arjunrn commented 4 years ago

If an account has enable_nat set to false then sevenseconds will not create NAT for that account. Existing subnets and NATs won't be deleted. This config items is also True by default.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.04%) to 24.307% when pulling 61cbb76ba730e8cecf81cb70b0e31823aea9212a on add-drop-nat-config into 4b6dc1c1ed5b8fb86530c0ce7eee91a2a42e30cd on master.

codecov-io commented 4 years ago

Codecov Report

Merging #94 into master will decrease coverage by 0.03%. The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   24.30%   24.26%   -0.04%     
==========================================
  Files          24       24              
  Lines        2016     2019       +3     
==========================================
  Hits          490      490              
- Misses       1526     1529       +3
Impacted Files Coverage Δ
sevenseconds/config/vpc.py 7.49% <0.00%> (-0.05%) :arrow_down:
sevenseconds/cli.py 63.49% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b6dc1c...61cbb76. Read the comment docs.

aermakov-zalando commented 4 years ago

LGTM, but I'd bump the config version to avoid people accidentally recreating the gateways.

aermakov-zalando commented 4 years ago

👍

arjunrn commented 4 years ago

:+1:

mikkeloscar commented 4 years ago

:+1: