linki commented 4 years ago

This adds the case of resending a validation email if the renewal is pending (in addition to the top level pending case).

~~This wouldn't be covered by the 4 weeks expiry case because the cert is still ISSUED and therefore enters the continue block.~~ This would also eventually be covered by the 4 weeks expiry case below but seems that AWS marks them as pending already before. So let's just send those mails if there are pending renewals.

Note that RenewalSummary isn't present on all certs (gets added after first renewal I think) hence the if in.

codecov-commenter commented 4 years ago

Codecov Report

Merging #95 into master will decrease coverage by 0.02%. The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   24.26%   24.24%   -0.03%     
==========================================
  Files          24       24              
  Lines        2019     2021       +2     
==========================================
  Hits          490      490              
- Misses       1529     1531       +2

Impacted Files	Coverage Δ
sevenseconds/config/acm.py	`9.67% <0.00%> (-0.33%)`	:arrow_down:
sevenseconds/config/securitygroup.py	`39.78% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 36929d7...c1439e2. Read the comment docs.

coveralls commented 4 years ago

Coverage decreased (-0.02%) to 24.283% when pulling c1439e20c7605b1acbbef6cf3d3b5af0aa5c6411 on resend-pending-renewal into 36929d7fd99a49ac26b4f444b0ee1a115640bac7 on master.

linki commented 4 years ago

Hmm :disappointed: This seems to be already covered here. I'm closing this for now and wait if any alerts pop up again.

zalando-stups / sevenseconds

Resend renewal validation even if expiry is more than 4 weeks out #95

Codecov Report