search

zalando-stups / sevenseconds

THIS PROJECT IS NOT LONGER ACTIVELY MAINTAINED
https://pypi.python.org/pypi/stups-sevenseconds
Other
66 stars 17 forks source link

Resend validation email 8 weeks before expiration instead of 4 #96

Closed linki closed 4 years ago

linki commented 4 years ago

We currently trigger to resend validation emails via 7s 4 weeks before certificates are expiring.

AWS automatically starts sending out renewal emails 60 days before expiration for about two weeks (source). After that it seems the first warning email is sent to users: for instance on Jun 2 we got an email for a certificate expiring on Jul 17 (45 days left).

Just to avoid unnecessary emails to our users let's resend emails via 7s before those 45 days as well.

codecov-commenter commented 4 years ago

Codecov Report

Merging #96 into master will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   24.79%   24.79%           
=======================================
  Files          25       25           
  Lines        2033     2033           
=======================================
  Hits          504      504           
  Misses       1529     1529
Impacted Files Coverage Δ
sevenseconds/config/acm.py 10.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f02dc1...2892751. Read the comment docs.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 24.791% when pulling 28927519ee782fbd9a767f45bde6ce67a8fdab01 on extend-earlier into 3f02dc18f42cff98c65518205bb8db04acf746c6 on master.

aryszka commented 4 years ago

:+1:

linki commented 4 years ago

:+1:

linki commented 4 years ago

:+1:

mikkeloscar commented 4 years ago

:+1: