zalando-stups / stups-etcd-cluster

Etcd cluster appliance for the STUPS (AWS) environment
Other
29 stars 9 forks source link

Ensure we do not create a cluster with no quorum #1

Closed feikesteenbergen closed 8 years ago

feikesteenbergen commented 8 years ago

During initializing etcd.py registers the member to the etcd-cluster. It can however happen that after registration etcd is not starting correctly.

If this happens multiple times, we can get into the situation that the cluster has no quorum

Example:

3 node cluster, 3 new nodes added

Members: 6, quorum: 3, but no new correct nodes.

Perhaps we should implement strict reconfig check:

https://github.com/coreos/etcd/blob/master/Documentation/runtime-configuration.md#strict-reconfiguration-check-mode--strict-reconfig-check

Seems to be fixed in https://github.com/coreos/etcd/commit/6974fc63ed8754537252289d6d5fcc64b45b5ac1

feikesteenbergen commented 8 years ago

Fixed in https://github.com/zalando/stups-etcd-cluster/pull/2