Add Route53 Records to the Stack for etcd.

zalando-stups / stups-etcd-cluster

Etcd cluster appliance for the STUPS (AWS) environment

Other

29 stars 9 forks source link

Add Route53 Records to the Stack for etcd. #10

Closed feikesteenbergen closed 8 years ago

feikesteenbergen commented 8 years ago

By explicitly naming the DNS records we want to create, we ensure the Cloud Formation Stack creation will fail if the Hosted Zone is specified incorrectly.

Basically: Replace runtime errors in HouseKeeper by creation error with CF template.

alexeyklyukin commented 8 years ago

Looks good to me

feikesteenbergen commented 8 years ago

This works ok, but currently the records persist when deleting the CF Stack. This happens because:

CF removes Route53 records as one of the first things
HouseKeeper loop is still running, recreates them
EC2 instances are terminated.

This results in the next attempt at creating the exact same CF Stack these records fail their creation: "Tried to create resource record set [name='example.com.', type='A'] but it already exists"