search

zalando-stups / stups-etcd-cluster

Etcd cluster appliance for the STUPS (AWS) environment
Other
29 stars 9 forks source link

update etcd to version v3.4.0 #51

Closed szuecs closed 5 years ago

szuecs commented 5 years ago

Signed-off-by: Sandor Szücs sandor.szuecs@zalando.de

szuecs commented 5 years ago

Hmm @CyberDem0n V3API has a lot of improvements and we only use v3api since more than a year. Do you think you would migrate to v3api?

CyberDem0n commented 5 years ago

etcd.py is using v2 API in order to get and change cluster topology (member list/add/remove). It is not doing that many calls therefore performance is not critical. I am not sure that changing the code in order to start supporting v3 is worth the time spent on it.

For now we can just conditionally add --enable-v2 argument like we already doing so with -listen-metrics-urls here. That will make it alive until v2 is completely ditched from the etcd codebase.

And here we should add env={'ETCDCTL_API': '2'}

szuecs commented 5 years ago

Should we also add somewhere a link to the upgrade checklist? https://github.com/etcd-io/etcd/blob/master/Documentation/upgrades/upgrade_3_4.md#upgrade-checklists

szuecs commented 5 years ago

https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/runtime-configuration.md#add-a-new-member-as-learner is also interesting to change to a more safe member add process

CyberDem0n commented 5 years ago

is also interesting to change to a more safe member add process

Agree, but that probably requires v3 API :(

aermakov-zalando commented 5 years ago

Are there any other changes needed?

CyberDem0n commented 5 years ago

No, but one should really try to upgrade 3.3 => 3.4 when the image is ready.

CyberDem0n commented 5 years ago

:+1:

aermakov-zalando commented 5 years ago

👍