search

zalando-stups / stups-etcd-cluster

Etcd cluster appliance for the STUPS (AWS) environment
Other
29 stars 9 forks source link

Feature/boto3 #7

Closed CyberDem0n closed 8 years ago

CyberDem0n commented 8 years ago

Addresses https://github.com/zalando/stups-etcd-cluster/issues/3 and https://github.com/zalando/stups-etcd-cluster/issues/4

a1exsh commented 8 years ago

I'm a bit alarmed that you change both code and the tests in the same commit(s) -- how do you know you're not breaking it with such a mix? It would look safer if you change only the code, keeping the same tests, when change/improve the tests (if needed at all).

CyberDem0n commented 8 years ago

It's not possible to change code and test separately because API provided by boto3 is not the same as was in old boto and it requires different mocks...

a1exsh commented 8 years ago

That's pity. Anyway, looks good.

feikesteenbergen commented 8 years ago

+1