search

zalando-stups / yourturn

The frontend/developer console for the STUPS infrastructure
http://docs.stups.io/en/latest/components/yourturn.html
Apache License 2.0
8 stars 6 forks source link

Add a `Support` to Application Form and Detail. #579

Closed GoWind closed 4 years ago

GoWind commented 4 years ago

There is a new support_url field in the application schema for a URL to file for support/feature issues. Add an input, Support in the application details form when creating/updating an application and when displaying application details Issue is tracked here

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.04%) to 83.971% when pulling e68a73229ed5a121b99eb7f1e47bc3d868732a08 on add_support_url into eb605a561a8bb6916d9b3ac883f1933a2849a718 on master.

tkrop commented 4 years ago

lgtm :+1:

GoWind commented 4 years ago

@thilp I updated the typo (Did a force push). can you check and give a thumbs up if it looks good ?

thilp commented 4 years ago

Yep but there were two typos :wink:

GoWind commented 4 years ago

I think my original phrasing was correct :P . An applies to words starting with a, e, i, o, u (an URL) and a to consonants a HTTPS URL

thilp commented 4 years ago

If my first link doesn't convince you, maybe this one from a well-known dictionary-maker will?

If the word begins with a consonant sound you would use a, such as "a dog" and "a balloon," as well as "a one" and "a unicorn."

What matters is the sound, not the letter. "URL" starts like "unicorn", and you wouldn't say "an unicorn", but "a unicorn". That link also uses "an FBI memo" as an example, which transposes to "HTTPS".

GoWind commented 4 years ago

@thilp Got it. Will make the changes as you suggested :)

GoWind commented 4 years ago

Done :)

thilp commented 4 years ago

:+1:

hjacobs commented 4 years ago

:+1: