zalando-zmon / opentracing-utils

Convenient utilities for adding OpenTracing support in your python projects
MIT License
20 stars 8 forks source link

fix duplicate args for collector_encryption #43

Closed vetinari closed 4 years ago

vetinari commented 4 years ago

this may happen if someone already uses collector_encryption...

codecov[bot] commented 4 years ago

Codecov Report

Merging #43 into master will decrease coverage by 0.26%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   98.63%   98.36%   -0.27%     
==========================================
  Files           9        9              
  Lines         366      368       +2     
==========================================
+ Hits          361      362       +1     
- Misses          5        6       +1     
Impacted Files Coverage Δ
opentracing_utils/tracers.py 85.00% <50.00%> (-1.85%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 456d995...a31f62c. Read the comment docs.

vetinari commented 4 years ago

:+1:

vetinari commented 4 years ago

see also https://github.com/zalando-zmon/opentracing-utils/commit/24821cab969cab6c8ef840a8977c60a4857ac15f#r43044567

vetinari commented 4 years ago

:+1:

mohabusama commented 4 years ago

👍