zalando-zmon / opentracing-utils

Convenient utilities for adding OpenTracing support in your python projects
MIT License
20 stars 8 forks source link

Add vendor dependency to README.md #46

Closed hexeberlin closed 3 years ago

hexeberlin commented 3 years ago

The libraries of the specific vendors (lightstep, instant, jaeger) are not part of dependencies.txt of opentracing-utils and have to be added to the dependencies of the application which is using opentracing-utils (otherwise it will fail, e.g. here https://app.eu.scalyr.com/y/7pqX2nx43k2). It would be nice to mention it in the README in the Usage part.

pitr commented 3 years ago

would you be able to open a PR to add them to README?

hexeberlin commented 3 years ago

@pitr https://github.com/zalando-zmon/opentracing-utils/pull/47

pitr commented 3 years ago

thank you!