zalando-zmon / opentracing-utils

Convenient utilities for adding OpenTracing support in your python projects
MIT License
20 stars 8 forks source link

Fix trace_requests() argument name in the README #50

Closed hexeberlin closed 3 years ago

hexeberlin commented 3 years ago

The argument accepted by trace_requests() is called ignore_url_patterns, not ignore_patterns.

codecov[bot] commented 3 years ago

Codecov Report

Merging #50 (2bd192b) into master (45699b0) will increase coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   98.36%   98.37%           
=======================================
  Files           9        9           
  Lines         368      370    +2     
=======================================
+ Hits          362      364    +2     
  Misses          6        6           
Impacted Files Coverage Δ
opentracing_utils/span.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 45699b0...2bd192b. Read the comment docs.

pitr commented 3 years ago

👍

vetinari commented 3 years ago

:+1: